port toranj test-013-off-mesh-route-traffic.py #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
- Coverage 41.72% 41.61% -0.12%
==========================================
Files 37 37
Lines 3851 3864 +13
==========================================
+ Hits 1607 1608 +1
- Misses 2244 2256 +12
Continue to review full report at Codecov.
|
priyankaCh22
commented
Sep 24, 2020
|
|
||
| dst.receive_udp_data(port, message, timeout) | ||
| time.sleep(delay) | ||
| src.send_udp_data(dst_address, port, message, src_address) |
There was a problem hiding this comment.
Not blocked by issue #68
tzm41
reviewed
Sep 25, 2020
qilinkang
reviewed
Sep 26, 2020
| @@ -446,7 +446,8 @@ def parse_list(list_string): | |||
| # For each line, skip the first two characters (which are `\t"`) and last character (`"`), then split the string | |||
| # using whitespace as separator. The first entry is the IPv6 address. | |||
| # | |||
| return [line[2:-1].split()[0] for line in list_string.split("\n")[1:-1]] | |||
| # return [line[2:-1].split()[0] for line in list_string.split("\n")[1:-1]] | |||
| return [line[2:-1].split()[0] for line in list_string.split("\n")[1:-2]] | |||
There was a problem hiding this comment.
Please run other test cases for this change.
There was a problem hiding this comment.
Tested with other relevant tests(slaac tests, inform_parent,parent_reset_child_recovery, child_attach_with_multiple_ip_addr) all are PASS.
tzm41
approved these changes
Sep 29, 2020
jwhui
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.